Fix CGMES GL import #2992
Merged
Fix CGMES GL import #2992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
zamarrenolm
approved these changes
Apr 30, 2024
|
the name can be kept for export ... |
Signed-off-by: Luma <zamarrenolm@aia.es>
annetill
approved these changes
Apr 30, 2024
Yes indeed, we could keep the name for export. This requires some more work though, as in your commit you're writing it whatever the input name was. Is that really worth the effort? |
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
This reverts commit cd71a84. Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
|
olperr1
pushed a commit
that referenced
this pull request
May 2, 2024
* Remove CoordinateSystem crsName from query * Not exporting the CoordinateSystem crsName * Remove use of crsName in unit tests * Fix warnings in modified files * Add unit test and clean others * Improve coverage and fix exception message * Fix typo and factorize common code Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com> (cherry picked from commit 84678f1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
No
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
GL import requires the
CoordinateSystemto havecrsNameequal to"WGS84", whereas this field is optionalWhat is the new behavior (if this is a feature change)?
GL import does not query for that parameter (and therefore does not check it)
Does this PR introduce a breaking change or deprecate an API?